Repository navigation
docs(dr): add CNPG StorageClass migration runbook (longhorn → longhorn-wffc) - #2424
Merged
Merged
Conversation
…n-wffc) Phase 2 of node right-sizing: a no-data-loss procedure to move CNPG clusters off the Immediate-binding longhorn StorageClass onto longhorn-wffc, by recreating one replica at a time (re-cloned from the primary) and switching the primary over last. Gated on platform#2421 (creates longhorn-wffc). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
📝 WalkthroughWalkthroughAdds a new runbook for migrating CloudNativePG clusters from Longhorn ChangesMigration Runbook Documentation
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/dr/cnpg-storageclass-migration.md`:
- Around line 59-67: The replica cleanup commands are not copy-pasteable because
$<inst> is invalid shell syntax. Update the example in the migration doc to use
a real shell variable or a consistent literal placeholder, and make the commands
in the delete/get steps reference that same value via the existing inst
placeholder so readers can run the sequence directly.
- Around line 75-81: The switchover example in the CNPG migration guide still
uses a placeholder patch target, which is not a valid user-facing command.
Update the example in the documentation flow around the cnpg promote/switchover
step to use the actual supported `kubectl cnpg promote $CL <migrated-replica>`
command, and if needed mention the fallback operator-supported flow explicitly
rather than the placeholder JSON.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 156f2128-feb3-44b8-8ad0-bb04f1c2ca79
📒 Files selected for processing (1)
docs/dr/cnpg-storageclass-migration.md
📜 Review details
🧰 Additional context used
📓 Path-based instructions (1)
docs/dr/**
📄 CodeRabbit inference engine (AGENTS.md)
Keep disaster-recovery runbooks and recovery procedures under
docs/dr/.
Files:
docs/dr/cnpg-storageclass-migration.md
github-project-automation
Bot
moved this from 🫴 Ready
to 🏃🏻♂️ In Progress
in 🌊 Project Board
…r step Addresses CodeRabbit: $<inst> is invalid shell — use a real `inst` variable with quoted expansions; and the spec.switchover patch was not a real CNPG field — replace with the cnpg-plugin promote (or plugin-free delete-primary-pod failover).
Contributor
Author
Fixed in a400f7a. The replica block now sets a real |
devantler
marked this pull request as ready for review
July 3, 2026 20:44
github-project-automation
Bot
moved this from 🏃🏻♂️ In Progress
to ✅ Done
in 🌊 Project Board
Contributor
|
🎉 This PR is included in version 1.96.4 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Phase 2 of node right-sizing. Phase 1 (#2421) adds the
longhorn-wffcWaitForFirstConsumer StorageClass; the four CNPG databases still sit on the oldImmediatelonghornclass, which is what strands their replicas on autoscaler overflow nodes (verified:umami-db-8is on a cx33 autoscale node).What
Adds a DR runbook documenting the no-data-loss procedure to migrate a CNPG cluster onto
longhorn-wffc: recreate one replica at a time (CNPG re-clones each from the primary), verify health/replication between every step, and switch the primary over last. Ordered least→most critical (umami → backstage → coroot → wedding).Operational note
Execution is gated on #2421 being promoted, merged, and deployed (the target StorageClass must exist first). I will run it cluster-by-cluster with verification gates once that lands — I do not self-promote #2421. Non-CNPG longhorn PVCs (kubescape/headlamp/actual-budget) are called out as backup-first, individual cases.